Skip to content

Conversation

@tifsy
Copy link
Collaborator

@tifsy tifsy commented Mar 4, 2025

✅ 요약

🪄 변경사항

  • 읽지 않은 편지 수를 프론트에서 처리하는 대신 api로 가져왔습니다

🖼️ 결과 화면 (선택)

💬 리뷰어에게 전할 말 (선택)

  • 화이팅 🥹

@tifsy tifsy added the ✨ Feature 기능 개발 이슈 label Mar 4, 2025
@tifsy tifsy self-assigned this Mar 4, 2025
@tifsy tifsy linked an issue Mar 4, 2025 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@wldnjs990 wldnjs990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!!!🥕🥕🥕🥕🥕🥕🥕🥕

@@ -0,0 +1,18 @@
import client from './client';

export interface UnreadLetters {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface엔 export가 없어도 될 거 같습니다!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

만약 다른 컴포넌트에서도 타입이 사용되는거라면 d.ts 파일에 들어가면 좋을거 같습니당

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 그렇네요 그렇게 수정하겠습니다!

@tifsy tifsy merged commit 911533d into develop Mar 4, 2025
1 check passed
@tifsy tifsy deleted the 65-get-unread-letters-count branch March 4, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 기능 개발 이슈

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 읽지 않은 편지 수 조회 기능 구현

3 participants